Pointer api updates #104
Merged
Pointer api updates #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yechun1
added a commit
to intel/ros2_intel_realsense
that referenced
this pull request
Nov 16, 2018
std::shared_ptr is not safe, replace with new pointer API from image_transport (ros-perception/image_common#104) Signed-off-by: Chris Ye <chris.ye@intel.com>
|
@mjcarroll Could the PR be merged? this PR is depended by applications which use image_transport APIs. If there is any issue left, please let me know, may be I could have a try to fix. |
|
@yechun1 If you could just give it a quick review, that would be very helpful. After I get another set of eyes on this, then I would be happy to get it merged. |
yechun1
added a commit
to intel/ros2_intel_realsense
that referenced
this pull request
Nov 27, 2018
std::shared_ptr is not safe, replace with new pointer API from image_transport (ros-perception/image_common#104) Signed-off-by: Chris Ye <chris.ye@intel.com>
|
@mjcarroll just reviewed the code, looks good to me. |
This was referenced Dec 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the free function variants of the image_transport API to no longer depend on needed a SharedPtr .
If you want to create image_transport Publishers or Subscribers as part of the subclass constructor, there was no way to get a shared pointer to the node instance itself to pass in. shared_from_this is not allowed in constructors for reasons listed here: https://en.cppreference.com/w/cpp/memory/enable_shared_from_this
If the previous behavior is desired, there is still the image_transport::ImageTransport object.
Requires ros2/message_filters#14